sindresorhus/eslint-plugin-unicorn

autofix `unicorn/prefer-array-some` can corrupt code easily

Closed

#2,007 opened on Dec 6, 2022

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)JavaScript (468 forks)user submission
bughelp wanted

Repository metrics

Stars
 (5,022 stars)
PR merge metrics
 (Avg merge 1d 16h) (399 merged PRs in 30d)

Description

code like

var res = $module.filter(selector.disabled).length > 0;

is currently autofixed to

var res = $module.some(selector.disabled);

but there is no $().some jQuery function, so the code is broken after autofix

IMHO the rule is legit, but there should be no autofix if the source cannot be 100% reasoned as an array

Contributor guide

Research direction
Analyze the autofix logic to prevent it from applying to non array objects such as jQuery collections. Add a type check to ensure the target has the some method.
Tech stack
javascript
Domain
developer experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75