sindresorhus/eslint-plugin-unicorn

`no-useless-fallback-in-spread`: Support ternary

Closed

#1,861 opened on Jul 19, 2022

View on GitHubContributor guide
 (4 comments) (7 reactions) (0 assignees)JavaScript (468 forks)user submission
enhancementhelp wanted

Repository metrics

Stars
 (5,022 stars)
PR merge metrics
 (Avg merge 1d 16h) (399 merged PRs in 30d)

Description

The rule currently does not detect ternary like this:

{...(foo ? {bar: true} : {})}

This can be safely be reduced to

{...(foo && {bar: true})}

Contributor guide

Research direction
The issue is to extend the `no useless fallback in spread` rule to detect ternary expressions like `{...(foo ? {bar: true} : {})}` and suggest using `{...(foo && {bar: true})}`. Start by examining the existing rule implementation in `rules/no useless fallback in spread.js` and its tests. Look for how it currently handles different patterns. The fix likely involves adding a check for `ConditionalExpression` nodes and ensuring the consequent is an object expression and the alternate is an empty object. Refer to the ESLint rule guide for AST node types. Implement the logic and add corresponding test cases.
Tech stack
javascript
Domain
toolingdeveloper experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Understanding of ASTFamiliarity with ESLint rule structureBasic JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75