sindresorhus/eslint-plugin-unicorn

no-null: false positive when null is used as function argument

Closed

#1,842 opened on Jun 15, 2022

View on GitHubContributor guide
 (2 comments) (1 reaction) (0 assignees)JavaScript (468 forks)user submission
enhancementhelp wanted

Repository metrics

Stars
 (5,022 stars)
PR merge metrics
 (Avg merge 1d 16h) (399 merged PRs in 30d)

Description

eslint unicorn v42.0.0

https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-null.md

Fails when null is used as function argument, even though this should pass. In fact this is even an example given in the "Pass" section: https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-null.md#pass

This works (no error):

const foo = Object.create(null);

but this fails:

drawingManager.setMap( null );

markers[ index ].setMap( null );

I think this shouldn't fail? I can't choose what argument types a function accepts in many cases (libraries). And if we want to have this error for functions we can control, it's better to give an error for no null arg when function is declared?

Contributor guide

Research direction
Examine the rule's AST visitor for CallExpression to ensure null arguments are only flagged when the function is defined in user code with a no null parameter annotation; look at how the rule currently handles arguments and check for modifications to exclude third party function calls.
Tech stack
javascripttypescript
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
JavaScriptESLint
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60