sindresorhus/eslint-plugin-unicorn

Rule proposal: Error when adding a class that begins with a dot`classList.add('.`

Closed

#1,837 opened on May 30, 2022

View on GitHubContributor guide
 (4 comments) (8 reactions) (0 assignees)JavaScript (468 forks)user submission
help wantednew rule

Repository metrics

Stars
 (5,022 stars)
PR merge metrics
 (Avg merge 1d 16h) (399 merged PRs in 30d)

Description

Description

Sometimes, we incorrectly try to add a class that begins with a dot, but linters and indeed browsers do not indicate that this is an error.

The error occurs because we use a dot in selectors for classname, but the dot is not part of the actual class name.

Fail

node.classList.add('.table-of-contents');

Pass

node.classList.add('table-of-contents')

Additional Info

No response

Contributor guide

Research direction
Look at existing ESLint rules that check classList methods, then implement a rule that warns when classList.add is called with a string starting with a dot.
Tech stack
javascript
Domain
tooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptESLint
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80