sindresorhus/eslint-plugin-unicorn

More powerful `new-for-builtins`

Closed

#1,835 opened on May 27, 2022

View on GitHubContributor guide
 (5 comments) (2 reactions) (0 assignees)JavaScript (468 forks)user submission
enhancementhelp wanted

Repository metrics

Stars
 (5,022 stars)
PR merge metrics
 (Avg merge 1d 16h) (399 merged PRs in 30d)

Description

Currently, new-for-builtins enforce builtins used either call or new.

My idea is to extend this rule to check all builtins.

  • Objects like JSON/Math/Reflect/Temporal should be neither call nor new
  • Objects from global objects like Intl.DateTimeFormat/Temporal.Now... should also be checked
  • Only fix cases new and call result the same Function('')/new Function(''), Error('')/new Error(''), use suggestion for other cases like new Symbol()(runtime error)

Contributor guide

Research direction
Study the current `new for builtins` rule implementation and list of builtins. Identify which builtins should never be called with `new` or `call`. Extend the rule logic to cover those cases.
Tech stack
javascriptnodejs
Domain
developer experiencetooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ESLintJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60