sindresorhus/eslint-plugin-unicorn

Rule proposal: mistaken parentheses

Closed

#1,796 opened on Apr 19, 2022

View on GitHubContributor guide
 (7 comments) (2 reactions) (0 assignees)JavaScript (468 forks)user submission
help wantednew rule

Repository metrics

Stars
 (5,022 stars)
PR merge metrics
 (Avg merge 1d 16h) (399 merged PRs in 30d)

Description

Description

There's a certain type of errors that can be hard to spot and will work fine. Since it's valid to do operations like || in this context is it even possible to have a rule that could notice when you might have meant the other one?

Fail

This is what you wrote

str.startsWith('str' || str.startsWith('str'))

Pass

This is what you meant

str.startsWith('str') || str.startsWith('str')

Additional Info

No response

Contributor guide

Research direction
Study the AST representation of logical expressions and function calls to detect misplaced parentheses. Look into creating an ESLint rule that checks for unnecessary parentheses around `||` inside function arguments.
Tech stack
javascripttypescript
Domain
developer experiencetooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
ESLint rule developmentAST traversal
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50