Rule proposal: `prefer-object-define-properties`

Repository metrics

Stars

5,022 stars (5,022 stars)

PR merge metrics

Avg merge 1d 16h (Avg merge 1d 16h)399 merged PRs in 30d (399 merged PRs in 30d)

Description

Object.defineProperty(matcher, 'logger', {
  value: () => {},
  writable: true,
})
Object.defineProperty(matcher, 'builder', {
  value: (value) => value.map(({ build }) => build()),
  writable: true,
})

Object.defineProperties(matcher, {
  logger: {
    value: () => {},
    writable: true,
  },
  builder: {
    value: (value) => value.map(({ build }) => build()),
    writable: true,
  }
})

Contributor guide

Research direction

Examine existing rules in eslint plugin unicorn for style and structure. Implement a new rule that detects consecutive Object.defineProperty calls on the same object and suggests using Object.defineProperties. Refer to the MDN documentation linked in the issue. Create tests following the project's testing pattern.

Tech stack

javascript

Domain

tooling

Issue type

Feature

DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.

2

Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.

1-3 hours

Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.

Stale

ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.

Clear

Prerequisites

JavaScriptESLint rule creation

Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.

85