sindresorhus/eslint-plugin-unicorn
Rule proposal: `no-useless-assign`
Closed
#1,693 opened on Jan 14, 2022
help wantednew rule
Repository metrics
- Stars
- (5,022 stars)
- PR merge metrics
- (Avg merge 1d 16h) (399 merged PRs in 30d)
Description
Description
I don't think no-unused-vars rule should check this case, because the variable is actually "used" in some case, only should not assign when it's a last use.
Fail
function foo(bar) {
bar = doSomething();
}
function foo(bar) {
bar = doSomething(bar);
}
function foo(bar) {
bar = doSomething(bar);
// ... do something else, but not using bar
}
Pass
function foo(bar) {
bar = doSomething(bar);
return bar;
}
function foo(bar) {
bar = doSomething(bar);
use(bar);
}
function foo(bar) {
function aInnerFunctionUsesBar() {
return bar;
}
bar = doSomething(bar);
// bar is not used but calling another function uses bar
aInnerFunctionUsesBar()
}