Rule change proposal regarding `prefer-ternary`: · sindresorhus/eslint-plugin-unicorn

(4 comments) (3 reactions) (0 assignees)JavaScript (468 forks)user submission

enhancementhelp wanted

Repository metrics

prefer-ternary currently only supports

'simple' if-else statements, where 'simple' means the consequent and alternate are each one line and have the same basic type and form.

Would it be possible to also detect the following example?:

const data = getData();
const defaultData = getDefaultData();

let items = defaultData;

if (data.length) {
    items = data;
}

const data = getData();
const defaultData = getDefaultData();

const items = data.length ? data : defaultData;

Research direction: Examine the existing implementation of the `prefer ternary` rule in `rules/prefer ternary.js`. Understand how it currently detects simple if else statements. Then modify the logic to also handle the pattern where a variable is initialized with a default value and then reassigned in an if statement. Ensure to add appropriate test cases in the test file, and update the documentation if needed. Consider existing comments in the issue for additional context.
Tech stack: javascripttypescript
Domain: tooling
Issue type: Feature
Difficulty: 3
Estimated time: 1-3 hours
Activity status: Stale
Clarity: Clear
Prerequisites: ESLint plugin developmentASTJavaScript/TypeScripteslint plugin unicorn conventions
Newbie friendliness: 45