sindresorhus/eslint-plugin-unicorn

Rule proposal: Prefer destructuring defaults to Object.assign/rest

Closed

#1,538 opened on Oct 2, 2021

View on GitHubContributor guide
 (10 comments) (3 reactions) (0 assignees)JavaScript (468 forks)user submission
help wantednew rule

Repository metrics

Stars
 (5,022 stars)
PR merge metrics
 (Avg merge 1d 16h) (399 merged PRs in 30d)

Description

I found this pattern and it looked like it could be standardized, but it probably isn't very common.

Fail

  const { foo, bar } = {
    foo: false,
    bar: 1,
    ...options,
  };

Pass

  const { foo = false, bar = 1} = options;

Contributor guide

Research direction
Study the existing ESLint rule structure in eslint plugin unicorn, particularly rules in the rules/ directory. Look at similar rules that detect object patterns. Implement the rule using AST selectors for ObjectExpression and variable declarators. Ensure to add unit tests and document the rule in the readme. Check issue comments for any additional constraints or preferences.
Tech stack
javascript
Domain
developer experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70