sindresorhus/eslint-plugin-unicorn

Rule proposal: `prefer-number-is-integer`

Closed

#1,460 opened on Aug 1, 2021

View on GitHubContributor guide
 (3 comments) (4 reactions) (0 assignees)JavaScript (468 forks)user submission
help wantednew rule

Repository metrics

Stars
 (5,022 stars)
PR merge metrics
 (Avg merge 1d 16h) (399 merged PRs in 30d)

Description

Use Number.isInteger. Not really sure if there's any benefit to using it. Maybe it's more performant. Makes the code marginally cleaner.

Fail

number % 1 === 0;

Pass

Number.isInteger(number);

Contributor guide

Research direction
Examine the eslint plugin unicorn repository to understand the rule creation pattern. Look at existing rules like `prefer number is nan` for guidance. In issue comments, maintainers may have discussed performance benefits; note that the proposal lacks strong motivation. Consider researching whether `Number.isInteger` is indeed faster than `number % 1 === 0`, and check if the rule can be implemented using the AST node `BinaryExpression` with operator `%`.
Tech stack
javascript
Domain
developer experiencetooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Familiarity with ESLint rule structureJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60