sindresorhus/eslint-plugin-unicorn

Rule proposal: `prefer-promise-all-settled`

Closed

#1,427 opened on Jul 16, 2021

View on GitHubContributor guide
 (9 comments) (1 reaction) (0 assignees)JavaScript (468 forks)user submission
help wantednew rule

Repository metrics

Stars
 (5,022 stars)
PR merge metrics
 (Avg merge 1d 16h) (399 merged PRs in 30d)

Description

Recently, I found I'm starting to use Promise.allSettled() instead of Promise.all(). I only use Promise.all() when all promises are 100% sure safe to resolve, but I'm not sure where is the boundary. I'd like to open up a discussion to see if we can do this safely.

Fail

const foo = await Promise.all(promises);

Pass

const foo = await Promise.allSettled(promises);

Contributor guide

Research direction
Review existing rules in the eslint plugin unicorn repository for patterns (e.g., in rules/ directory). Check the discussion comments for any maintainer feedback on the feasibility. Focus on implementing the logic that detects `Promise.all()` usage with an array of promises and suggests `Promise.allSettled()` when the promises may reject.
Tech stack
javascript
Domain
tooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript basicsESLint plugin development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55