sindresorhus/eslint-plugin-unicorn

Rule proposal: `no-query-selector-all-zero`

Closed

#1,404 opened on Jul 7, 2021

View on GitHubContributor guide
 (11 comments) (4 reactions) (0 assignees)JavaScript (468 forks)user submission
help wantednew rule

Repository metrics

Stars
 (5,022 stars)
PR merge metrics
 (Avg merge 1d 16h) (399 merged PRs in 30d)

Description

Avoid selecting an entire NodeList when only the first item is desired.

Fail

document.querySelectorAll("form")[0].addEventListener("submit", submitFunction);

Pass

document.querySelector("form").addEventListener("submit", submitFunction);

Contributor guide

Research direction
Review the repository's rule structure by examining an existing simple rule, such as 'rules/prefer add event listener.js'. Look at the test files in 'test/' to understand how rules are tested. The issue provides clear fail/pass examples. Check the comments for any additional requirements or concerns. Then implement the rule following the established pattern.
Tech stack
javascript
Domain
toolingdeveloper experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptESLint plugin knowledgeAST basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70