sindresorhus/eslint-plugin-unicorn

Rule proposal: `max-nested-calls`

Closed

#1,274 opened on May 14, 2021

View on GitHubContributor guide
 (3 comments) (7 reactions) (0 assignees)JavaScript (468 forks)user submission
help wantednew rule

Repository metrics

Stars
 (5,022 stars)
PR merge metrics
 (Avg merge 1d 16h) (399 merged PRs in 30d)

Description

Got the idea from this line.

Fail

mergeReports(await pMap(await mergeWithFileConfigs(uniq(paths), inputOptions, configFiles), async ({files, options, prettierOptions}) => runEslint(files, buildConfig(options, prettierOptions), {isQuiet: options.quiet})));

Pass

const uniqPaths = uniq(paths);
const mergedConfigs = await mergeWithFileConfigs(
  uniqPaths,
  inputOptions,
  configFiles
);
const reports = await pMap(
  mergedConfigs,
  async ({ files, options, prettierOptions }) =>
    runEslint(
      files, 
      buildConfig(options, prettierOptions),
      {isQuiet: options.quiet}
    )
);

mergeReports(reports);

Maybe with a configurable depth option.

These should all considered as "call"

  • CallExpression
  • ChainExpression > CallExpression
  • NewExpression
  • AwaitExpression > NodeTypesListedAbove.argument

Contributor guide

Research direction
Explore existing ESLint rules in eslint plugin unicorn to understand the pattern for implementing a new rule. Focus on the AST node types mentioned: CallExpression, ChainExpression, NewExpression, and AwaitExpression. Consider how to implement a configurable 'depth' option. Review the referenced line in xo/index.js for context. Check existing comments for any additional requirements or considerations.
Tech stack
javascript
Domain
tooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Understanding of ESLint rulesKnowledge of AST and JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40