[consistent-destructuring] incorrect fix for ts `in` type guard

Repository metrics

Stars

5,022 stars (5,022 stars)

PR merge metrics

Avg merge 1d 16h (Avg merge 1d 16h)399 merged PRs in 30d (399 merged PRs in 30d)

Description

const { a }: { a: string } & ({ b: number } | { c: number } | {}) = params
const value = 'b' in params ? params.b : 'c' in params ? params.c : null

// incorrect fixed
const { a, b, c }: { a: string } & ({ b: number } | { c: number } | {}) = params
const value = 'b' in params ? b : 'c' in params ? c : null

Contributor guide

Research direction

Examine the consistent destructuring rule source in rules/consistent destructuring.js. The rule currently incorrectly destructures properties when using the 'in' type guard. The fix should detect when the right hand side of 'in' operator is a parameter of a destructuring pattern and avoid destructuring that property. The playground link provides a clear reproduction. Also check the rule's tests to ensure the fix covers edge cases.

Tech stack

javascripttypescriptnodejs

Domain

toolingdeveloper experience

Issue type

Bug

DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.

3

Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.

1-2 days

Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.

Stale

ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.

Clear

Prerequisites

ESLint rule developmentTypeScript type guardsAST

Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.

50