sindresorhus/eslint-plugin-unicorn

Support check `.unshift()` in `no-array-push-push`

Closed

#1,019 opened on Jan 14, 2021

View on GitHubContributor guide
 (1 comment) (4 reactions) (0 assignees)JavaScript (468 forks)user submission
enhancementhelp wanted

Repository metrics

Stars
 (5,022 stars)
PR merge metrics
 (Avg merge 1d 16h) (399 merged PRs in 30d)

Description

no-array-push-push was added in #1015, only check .push(), opening a new issue to see if someone need this.

Fail

foo.unshift(1);
foo.unshift(2);

Pass

const length = foo.unshift(1);
foo.unshift(2);

Note: .unshift() is a little different, need change arguments order, and consider side effects in each call.(.push only consider side effect in second call).

Original issue #937

Contributor guide

Research direction
Study the existing no array push push rule implementation and adapt it for unshift, handling reversed argument order and side effects.
Tech stack
javascript
Domain
developer experiencetooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptESLint plugin development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60