sindresorhus/Settings

Make it work automatically when used in a menu bar app

Open

#40 opened on Aug 1, 2019

View on GitHubContributor guide
 (11 comments) (2 reactions) (0 assignees)Swift (123 forks)user submission
enhancementhelp wanted

Repository metrics

Stars
 (1,534 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I make an app, just with statusbar and menu item. And I add preferences in the menu item. But when the Preferences open, I can't use cmd+w close it. Only has to click red close button in the left up corner.

Contributor guide

Research direction
Check the preferences window configuration: ensure it has proper key equivalent for close (Cmd+W) or that the window delegate handles close. Investigate if the window is a panel or standard window and if it's set to be non exempt from key handling.
Tech stack
swift
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
SwiftmacOS development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75