shawnbot/html-table-stream

Write a better algorithm for "flattening" spanning cells

Open

#2 opened on Apr 2, 2015

View on GitHub
 (0 comments) (0 reactions) (1 assignee)HTML (1 fork)github user discovery
help wanted

Repository metrics

Stars
 (6 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

The current one for column headers works well for this table, but I need more examples. Also, there is currently zero support for data cells with colspan or rowspan attributes.

Tests should cover:

  • Spanning column headers. E.g. for this table the last three columns should be parsed as "Week Ending Mar 27", "Week Ending Mar 20", and "2015 Feb":

    image

  • Whitespace: <br> should be treated as space, whitespace trimmed from the left and right, and all other whitespace collapsed into single spaces.

  • Spanning data cells. If a <td> has colspan="2" then the resulting row object should have that cell's text value for both of the keys of the columns it spans. Likewise, if it has rowspan="2", then the following row should "inherit" this row's value for this column.

Contributor guide

Research direction
Study the current flattening algorithm in the codebase, gather sample HTML tables with colspan and rowspan, and design a test suite covering the specified cases.
Tech stack
javascriptnodejs
Domain
backendcli
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
JavaScriptNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50