shari-sushi/V-Kara-Lists

modalで閉じたくてenterを押すと後ろのsubmit等が反応してしまっている

Open

#289 opened on Feb 9, 2025

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (3 forks)auto 404
bugfrontendgood first issue

Repository metrics

Stars
 (20 stars)
PR merge metrics
 (Avg merge 4d 6h) (25 merged PRs in 30d)

Description

ログイン失敗→modal表示→enterする→modalそのままに再度ログインのリクエストを飛ばしてる

という、お互いに不幸な状態になってる。 modal内にロックするのと、enterで閉じれるようにしたい。 modalの仕様がイケてないといえばそうかもしれないので、閉じれるようにするだけのタスク分割でも可。

Contributor guide

Research direction
Investigate the modal component to ensure the Enter keypress event is captured within the modal and does not propagate to underlying elements. Add a keydown event listener to the modal that stops propagation when Enter is pressed, and also close the modal on Enter.
Tech stack
typescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
HTMLCSSJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85