shari-sushi/V-Kara-Lists

初回レンダリング後のheaderのレスポンシブ表示切替えが死んでる

Open

#209 opened on Jun 16, 2024

View on GitHub
 (4 comments) (0 reactions) (0 assignees)TypeScript (3 forks)auto 404
frontendgood first issue

Repository metrics

Stars
 (20 stars)
PR merge metrics
 (Avg merge 4d 6h) (25 merged PRs in 30d)

Description

#201 のレビューミス回収issue

Layout.tsx(同名のファイルが複数あるので注意)で画面サイズを取得する際に、useEffectを用いることでhydrationエラーを防いでいる。 しかし、useEffectの第２引数が空配列なので、初回レンダリング後に画面幅が変わった際でも画面表示が変わらなくなってしまった。 第２匹数に依存を入れて修正する必要がある。

Contributor guide

Research direction
Check the useEffect in Layout.tsx that uses an empty dependency array for window size. Add a dependency on the window size (e.g., by using a state variable that updates on resize) so that the responsive header toggles correctly when the screen width changes.
Tech stack
typescriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80