serverless/serverless-google-cloudfunctions

Use jest mocks rather than sinon

Open

#104 opened on Jul 5, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (124 forks)auto 404
enhancementhelp wanted

Repository metrics

Stars
 (275 stars)
PR merge metrics
 (PR metrics pending)

Description

We could get rid of the sinon dependency and use jest mocks instead.

Contributor guide

Research direction
Find all sinon.mock() and sinon.stub() calls in test files and replace them with jest.fn() or jest.spyOn() equivalents. Ensure tests still pass.
Tech stack
javascriptjestnodejs
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90