serverless-nextjs/serverless-next.js

Allow overriding of lambda@edge origin-request for custom paths

Open

#892 opened on Feb 1, 2021

View on GitHub
 (5 comments) (0 reactions) (0 assignees)TypeScript (447 forks)batch import
buggood first issue

Repository metrics

Stars
 (3,998 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Is your feature request related to a problem? Please describe. I have a custom path on my NextJS app that I want to route through a custom Lambda@Edge function of my own, but this code overrides it even if I provide it in the input configuration.

Describe the solution you'd like Allow the override to happen, I don't think it makes sense to have a configuration that gets overridden always.

Describe alternatives you've considered Since I can't do this override I have to manually edit the default-lambda code using a custom script on the build.postBuildCommands.

Additional context

nextApp:
  component: '@sls-next/serverless-component@1.19.0-alpha.30'
  inputs:
    cloudfront:
      /custom-route/*:
        viewerProtocolPolicy: 'redirect-to-https'
        allowedHttpMethods:
          ['GET', 'HEAD', 'OPTIONS', 'PUT', 'POST', 'PATCH', 'DELETE']
        minTTL: 0
        maxTTL: 31536000
        defaultTTL: 0
        forward:
          cookies: 'all'
          queryString: true
        compress: true
        lambda@edge:
          origin-request: THIS_GETS_OVERRIDEN_WITH_THE_DEFAULT_LAMBDA_ARN

Contributor guide

Research direction
The issue points to code at packages/serverless components/nextjs component/src/component.ts line 647 where origin request is overridden. Investigate the logic that determines when to override and how to allow user provided lambda ARN. Check if there are existing tests or configuration handling in that file. Engage in comments to clarify the expected behavior.
Tech stack
typescriptnextjsawsnodejs
Domain
backendcloudinfrastructure
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Understanding of serverless nextjs component structureAWS CloudFront and Lambda@Edge basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35