scrapinghub/arche

Make 0 items outcome more visible

Open

#12 opened on Jan 3, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (17 forks)auto 404
Type: Featuregood first issue

Repository metrics

Stars
 (47 stars)
PR merge metrics
 (PR metrics pending)

Description

Currently if a filtered job returns 0 items, the first test simply fails. While there're some hints which point on the number of returned errors - 0it, it's not visible enough.

g = Gatf(source='2235/1276/18', 
         schema='schemas/Netflix-FTE/netflix-show.json',
         target='2235/1276/18',
         filters=[("META_TEMPLATE_NAME", "=", ["Title"])],
         expand=False)

Contributor guide

Research direction
Find the test that fails with '0it' and add a clear message when 0 items are returned.
Tech stack
python
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Python
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85