schickling/chromeless

Better error handling when error occurs in expressionResult

Open

#207 opened on Aug 9, 2017

View on GitHub
 (0 comments) (3 reactions) (0 assignees)TypeScript (606 forks)batch import
APIenhancementhelp wanted

Repository metrics

Stars
 (13,240 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

const { Chromeless } = require('chromeless')

async function run() {
  const chromeless = new Chromeless()

  const screenshot = await chromeless
    .goto('https://www.google.com')
    .click('.icon') //click
    .click('.passenger') //click
    .wait('#resultStats')
    .screenshot()

  console.log(screenshot) // prints local file path or S3 url

  await chromeless.end()
}
run().catch(console.error.bind(console))

the error message: Error: TypeError: Cannot read property 'click' of undefined at expressionResult (:8:17) at :10:11 at :16:7 at D:\git\headless\node_modules\chromeless\dist\src\util.js:302:31 at step (D:\git\headless\node_modules\chromeless\dist\src\util.js:40:23) at Object.next (D:\git\headless\node_modules\chromeless\dist\src\util.js:21:53) at fulfilled (D:\git\headless\node_modules\chromeless\dist\src\util.js:12:58 )

I could not know which click failed from the error message.

Contributor guide

Research direction
Investigate the source code to locate the expressionResult function (likely in src/util.ts or similar). Add better error messages that indicate which step (e.g., click) failed, possibly by passing a step name or index. Ensure the error propagates clearly to the user. Check the existing error handling patterns in the codebase.
Tech stack
typescriptnodejs
Domain
developer experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Familiarity with Chromeless libraryBasic TypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70