saveourtool/diktat

Detect useless scoped functions

Open

#972 opened on Jul 7, 2021

View on GitHubContributor guide
 (0 comments) (0 reactions) (1 assignee)Kotlin (40 forks)github user discovery
enhancementgood first issuehelp wantedneeded

Repository metrics

Stars
 (571 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Implement the rule, which will detect useless scoped functions, and remove extra actions. For example, in a bundle of let - run it can be quite often met situations, when run contain single statement, which is actually will work without run:

someValue?.let {
                foo()
            }
                ?: run {
                    bar()
                }

Expected behavior

someValue?.let {
                foo()
            }
                ?: bar()

Contributor guide

Research direction
Examine the existing rule structure in diktat and implement a new rule to detect unnecessary scoped function calls like `run` with a single statement.
Tech stack
kotlin
Domain
devtools
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Kotlin
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70