sanic-org/sanic

ASGI exceptions outside handlers should be able to pass status

Open

#2,718 opened on Mar 19, 2023

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Python (1,515 forks)batch import
beginnerhelp wanted

Repository metrics

Stars
 (17,623 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

An exception raised in the lifecycle (but not handler) of a request on an ASGI-served application should be able to pass a status code.

In my experiment, raising a BadRequest in asgi.py will cause the ASGI server return 500 error, instead of 400. This seems out of the scope of this PR, but I am wondering whether we should change the raised error to ServerError or others before we figure out how to let ASGI server return a 400 error.

Originally posted by @ChihweiLHBird in https://github.com/sanic-org/sanic/pull/2606#discussion_r1133448078

Contributor guide

Research direction
Investigate how ASGI exceptions are handled in the Sanic lifecycle and modify the exception handling to allow passing custom status codes.
Tech stack
python
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonASGI
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60