saberland/saber

Show a notifier when it's required to restart server

Open

#509 opened on Oct 8, 2019

View on GitHubContributor guide
 (3 comments) (1 reaction) (0 assignees)JavaScript (127 forks)batch import
contribution welcomehacktoberfesttype: feature

Repository metrics

Stars
 (2,151 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Feature request

What problem does this feature solve?

https://github.com/saberland/saber/blob/83c18a706637fedccdbe0ad34566218dc5780d94/packages/saber/lib/plugins/extend-node-api.js#L89

People often modify saber-config.js, saber-node.js and forget to restart server.

How should this be implemented in your opinion?

Maybe use https://www.npmjs.com/package/node-notifier, and expose it in saber-utils package

Contributor guide

Research direction
Examine the referenced file `packages/saber/lib/plugins/extend node api.js` and understand how to add a notification using the `node notifier` package. Consider exposing the notifier in the `saber utils` package and triggering it when configuration files change.
Tech stack
javascriptvuenodejs
Domain
developer experiencetooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Node.jsnpm
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65