rust-lang/rustfmt

Visual IndentStyle is broken on impl with where clause

Open

#3,071 opened on Sep 30, 2018

View on GitHub
 (12 comments) (0 reactions) (1 assignee)Rust (760 forks)batch import
I-poor-formattingUO-indent_stylegood first issueonly-with-option

Repository metrics

Stars
 (4,893 stars)
PR merge metrics
 (Avg merge 50d 8h) (8 merged PRs in 30d)

Description

Test code:

struct A<T>
    where T: Send
{
    x: u32,
}

impl<T> A<T> where T: Send
{
    fn foo() {}
}

The impl block is expected to be formatted as:

impl<T> A<T>
    where T: Send
{
    fn foo() {}
}

Everything is ok for indent_style: "Block".

rustfmt version:

rustfmt 0.99.5-nightly (90692a59 2018-09-26)

Contributor guide

Research direction
Examine how VisualIndentStyle is applied to impl blocks with where clauses. Look at the formatting logic for where clause indentation.
Tech stack
rust
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RustGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80