rust-lang/rust-clippy

Lint x != _ || x != _

Open

#853 opened on Apr 12, 2016

View on GitHubContributor guide
 (3 comments) (0 reactions) (1 assignee)Rust (1,391 forks)batch import
A-lintL-correctnessT-middlegood first issue

Repository metrics

Stars
 (10,406 stars)
PR merge metrics
 (Avg merge 19d 22h) (113 merged PRs in 30d)

Description

Also probably x == _ && x == _. This is either a duplicate (if both _ are equal) or always false (true for the former).

Contributor guide

Research direction
Examine the existing lint for 'x == && x == ' and similar patterns in the Clippy source code under clippy lints/src/.
Tech stack
rust
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70