rsms/fb-mac-messenger

React component names changed, menus no longer work

Open

#308 opened on Jul 16, 2016

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Objective-C (232 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (2,837 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

In these lines, we try to find the settings gear by looking for the MessengerMasterViewHeader component. Unfortunately, this component no longer seems to exist, when looking through the React debugger:

screen shot 2016-07-16 at 1 54 09 am

Instead, we seem to just have components called k, m, o, and other generic names, so the app's javascript can't find the components it's looking for any more.

This is likely the cause of https://github.com/rsms/fb-mac-messenger/issues/305 as well.

Contributor guide

Research direction
Inspect the React component tree using React DevTools to identify the new component names that replaced 'MessengerMasterViewHeader'. Then update the references in the JavaScript file (app/main.js lines 160-170) accordingly.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70