roman-corgi/corgidrp

Add option to pass in a relative scaling instead of peak_flux for klip_fm.inject_psf

Open

#367 opened on Mar 25, 2025

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Python (10 forks)auto 404
good first issue

Repository metrics

Stars
 (16 stars)
PR merge metrics
 (PR metrics pending)

Description

*Is your feature request related to a problem? Please describe. Injecting with a peak flux assumes you understand the normalization of the model PSF. Sometimes we haven't understood yet, but know how much fainter than the model PSF we want to inject (a relative scaling).

Describe the solution you'd like Add option to inject psf using a relative scaling factor rather than specifying the peak flux of the injected source.

Additional context For beyond v2.0

Contributor guide

Research direction
Investigate the existing inject psf function's peak flux parameter and implement an alternative relative scaling input, ensuring compatibility with the existing codebase and documentation.
Tech stack
python
Domain
backenddata
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Pythonastropy
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60