roman-corgi/corgidrp

Need to double check the PAM Name keywords vs. their H/V positions

Open

#291 opened on Jan 29, 2025

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)Python (10 forks)auto 404
Feature Request/Upgradegood first issuelow priority

Repository metrics

Stars
 (16 stars)
PR merge metrics
 (PR metrics pending)

Description

Is your feature request related to a problem? Please describe. The PAM name Keywords CFAMNAME, DPAMNAME, FPMAMNAME, LSAMNAME, SPAMNAME will be set by the SSC to the closest "Enum" value based on the closest match to the H and V values in the Tables on this webpage. This means that the mechanism might be incorrectly position, but still give a valid PAMNAME keyword.

Describe the solution you'd like We want a check early on the in DRP that checks that the PAMS are within [TBD] units of the desired H and V positions. It would then write the correct Enum to either a new keyword or overwrite the previous value (while still saving the original somehow). We might want some kind of step function that is called "update_headers", where we'd put other similar types of checks or adjustments.

Additional context Add any other context or screenshots about the feature request here.

Contributor guide

Research direction
Review the PAM name keywords and their corresponding H/V positions from the referenced table, then implement a check in a new 'update headers' step function to verify alignment and update the keyword if necessary.
Tech stack
python
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60