redux-saga/redux-saga

babel-plugin-redux-saga crashes sagas - Object.defineProperty called on non-object

Closed

#2,088 opened on Jun 27, 2020

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)JavaScript (1,987 forks)batch import
bughelp wanted

Repository metrics

Stars
 (22,505 stars)
PR merge metrics
 (PR metrics pending)

Description

Steps to reproduce

yield something that isn't an object.

Description of the bug/issue

The plugin should check that that it transforming an object before calling defineProperty.

TypeError: Object.defineProperty called on non-object

Example

// I know there is nothing to yield here, but this would normaly be fine without the plugin 
function* foo() {
  yield 20; //  crash: Object.defineProperty called on non-object
}

Contributor guide

Research direction
Inspect the babel plugin code to ensure it checks for object type before calling Object.defineProperty.
Tech stack
javascript
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptBabelredux saga
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55