reactorlabs/rir

User-Provided Function Context

Open

#910 opened on Sep 22, 2020

View on GitHub
 (2 comments) (0 reactions) (1 assignee)C++ (19 forks)github user discovery
help wanted

Repository metrics

Stars
 (61 stars)
PR merge metrics
 (Avg merge 1m) (1 merged PR in 30d)

Description

A RIR function (ie. a DispatchTable) should have a user-provided context, that is a minimal context required to enter a function. This needs:

  1. Add a Context to the dispatch table
  2. Add a api to set a context on the dispatch table (for now this can be very simple, e.g. just the numerical representation of a context) related: #911
  3. Ensure the context is checked when calling the function (should be enough to check in dispatch in interp.cpp)
  4. Ensure the context is checked when entering an inlined section of the function

Contributor guide

Research direction
Examine the dispatch function in interp.cpp to understand how RIR functions are invoked, and identify where to add a context check. Also review issue #911 for related context on contexts.
Tech stack
cpp
Domain
compilers
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65