reactorlabs/rir

ScopeResolution: unnecessary execution of code

Open

#1,274 opened on Apr 1, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (19 forks)github user discovery
buggood first issuepir

Repository metrics

Stars
 (61 stars)
PR merge metrics
 (Avg merge 1m) (1 merged PR in 30d)

Description

The code here will run on every iteration of this pass. Even if it does not change the 'changed' flag , the method fromContext should not be invoked more than is required.

https://github.com/reactorlabs/rir/blob/0c2896fbc82f505e61ed8db416e113905d8f2237/rir/src/compiler/opt/scope_resolution.cpp#L317

Contributor guide

Research direction
Review the scope resolution.cpp file around line 317. Understand the loop that iterates and the fromContext call. Identify if fromContext can be moved outside the loop or if a condition can prevent its unnecessary execution. Consider how the 'changed' flag is used and ensure the fix does not alter the logic.
Tech stack
cpp
Domain
compilers
Issue type
Performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75