reactjs/react-modal

Focus escapes modal when radio buttons in modal

Open

#636 opened on Mar 29, 2018

View on GitHub
 (8 comments) (11 reactions) (0 assignees)JavaScript (828 forks)batch import
accessibilitybugeasygood first issue

Repository metrics

Stars
 (7,294 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Summary:

When there are radio buttons in a modal, you can escape focus with shift-tab.

Steps to reproduce:

Steps are included in the test case below

Expected behavior:

You should not be able to escape the modal's focus

Link to example of issue:

https://codesandbox.io/s/my9vm34m68

Additional notes:

Not sure if it's related specifically to radio buttons, but that is what is causing the issue for me

Contributor guide

Research direction
Investigate the focus trapping logic in the modal component, specifically how radio buttons are handled during tab navigation. Check the focus state management and event handlers for shift+tab to ensure focus remains within the modal.
Tech stack
reactjavascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
React
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75