reactjs/react-modal

Fails to render using renderToStaticMarkup

Open

#538 opened on Oct 22, 2017

View on GitHub
 (1 comment) (2 reactions) (0 assignees)JavaScript (828 forks)batch import
help wantedneeds info

Repository metrics

Stars
 (7,294 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Summary:

Fails when rendering using renderToStaticMarkup

Steps to reproduce:

call renderToStaticMarkup with react-modal anywhere in the tree

Expected behavior:

Link to example of issue:

https://codesandbox.io/s/rwnvq00p8p

Additional notes:

I have made a failing test here

Contributor guide

Research direction
The issue is that react modal fails when used with renderToStaticMarkup. The reporter provided a failing test at https://github.com/salzhrani/react modal/tree/static markup. Investigate why the modal component does not render in static markup, likely due to its use of portals or DOM specific behavior. Check the component's lifecycle and DOM interactions to make it compatible with server side rendering.
Tech stack
reactjavascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
React basicsrenderToStaticMarkup understandingTest setup
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45