reactjs/react-modal

Replace focus trap with `inert`

Open

#1,011 opened on Mar 29, 2023

View on GitHubContributor guide
 (1 comment) (4 reactions) (0 assignees)JavaScript (828 forks)batch import
accessibilitybrowser apicombining librariesdependenciesdiscussioneasyfeaturegood first issue

Repository metrics

Stars
 (7,294 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Now that browsers have good support for inert, could we consider replacing the custom focus trap logic with this?

Alternatively, we could use the dialog element so we get this behaviour for free.

Contributor guide

Research direction
Investigate browser support for the inert attribute and dialog element, and explore how to replace the current focus trap logic with inert or dialog in the react modal component.
Tech stack
reactjavascript
Domain
accessibilityfrontend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactJavaScriptAccessibility
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70