radareorg/radare2

Merge/Kill quintuplicate JSON implementations

Open

#12,870 opened on Jan 21, 2019

View on GitHubContributor guide
 (4 comments) (0 reactions) (0 assignees)C (3,229 forks)batch import
Hacktoberfestenhancementgood first issuejsonrefactor

Repository metrics

Stars
 (23,826 stars)
PR merge metrics
 (Avg merge 16h 24m) (99 merged PRs in 30d)

Description

Now we have:

  • pj.c
  • sdbjson
  • dsojson
  • handmade printf json
  • r_json

We must only keep pj.c and likely have sdb uses pj.c too.

Contributor guide

Research direction
Identify all JSON implementation files in the codebase, analyze their interfaces and dependencies, and propose a plan to consolidate them into pj.c while ensuring sdb uses the unified implementation.
Tech stack
c
Domain
backendtooling
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
CCodebase navigation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60