quran/quran.com-frontend-next

Standardize using dispatch

Open

#642 opened on Oct 31, 2021

View on GitHubContributor guide
 (8 comments) (0 reactions) (0 assignees)TypeScript (616 forks)auto 404
help wanted

Repository metrics

Stars
 (1,888 stars)
PR merge metrics
 (PR metrics pending)

Description

In our codebase we are having 2 ways to call dispatch:

  1. dispatch(decreaseQuranTextFontScale())
  2. dispatch({ type: toggleIsOpen.type });

We should follow one of them for consistency.

Contributor guide

Research direction
Find all dispatch calls in the codebase. Determine which pattern (action creator or object) is more common or preferred. Then update all occurrences to use that pattern.
Tech stack
typescriptreact
Domain
frontend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptRedux
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90