quran/quran.com-frontend-next

[feature]: Ayah actions popover menu should close automatically once action is taken

Open

#1,826 opened on Oct 24, 2022

View on GitHubContributor guide
 (10 comments) (0 reactions) (1 assignee)TypeScript (616 forks)auto 404
good first issuehelp wanted

Repository metrics

Stars
 (1,888 stars)
PR merge metrics
 (PR metrics pending)

Description

Is there an existing issue for this feature?

  • There is no exsiting issue for this feature

Summary

When opening the Ayah actions popover menu let's say to view Tafsirs or repeat settings, the popover menu stays opened even after the action modal e.g. repeat settings is closed. We should close the popover menu once action is taken. Actions that should this apply to are:

  • Copying verse-related data inside Advanced Copy modal.
  • Starting repeating the Ayah inside Repeat Settings modal.
  • Viewing Tafsirs of Ayah inside Tafsirs modal.

Oct-24-2022 15-52-38

Your purposed solution for this feature

This could be achieved by making use of onActionTriggered inside src/components/Verse/OverflowVerseActionsMenuBody.tsx.

Contributor guide

Research direction
Examine the onActionTriggered prop in src/components/Verse/OverflowVerseActionsMenuBody.tsx to programmatically close the popover menu after an action completes.
Tech stack
typescriptreactnextjs
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75