quickwit-oss/chitchat

ports in unit tests.

Open

#37 opened on Apr 8, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Rust (65 forks)github user discovery
good first issuehelp wanted

Repository metrics

Stars
 (374 stars)
PR merge metrics
 (Avg merge 22h 45m) (1 merged PR in 30d)

Description

Unit tests are using manually cherry-picked port that do not overlap... That is a deep paper cut, but also it might break unit tests if the system has this port busy by a different application.

We can probably find a way to rely on port 0 in unit tests and have the OS pick an available port for us.

Contributor guide

Research direction
Find the unit test files that use hardcoded port numbers and modify them to use port 0 so the OS assigns an available port.
Tech stack
rust
Domain
backenddistributed systems
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rustunit testing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80