pytorch/pytorch

Inductor: delete code that extracts out sizevars by inspecting tensor inputs to find a size that handled it

Closed

#102,870 opened on Jun 2, 2023

View on GitHubContributor guide
 (8 comments) (0 reactions) (1 assignee)Python (28,884 forks)batch import
better-engineeringgood first issuemodule: inductortriaged

Repository metrics

Stars
 (102,440 stars)
PR merge metrics
 (Avg merge 1d 10h) (42 merged PRs in 30d)

Description

🐛 Describe the bug

This is no longer needed since we now pass in all free symbols as explicit arguments

Versions

main

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @aakhundov @ColinPeppler @Xia-Weiwen @ngimel

Contributor guide

Research direction
Understand the current code that extracts sizevars from tensor inputs in Inductor, then identify where this logic is redundant because free symbols are now passed as explicit arguments, and finally delete the redundant code while ensuring tests pass.
Tech stack
python
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonPyTorch
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60