pypa/pipx

cli parameter parsing is corrupted by strict positional

Closed

#1,444 opened on Jun 7, 2024

View on GitHubContributor guide
 (3 comments) (0 reactions) (0 assignees)Python (591 forks)batch import
bughelp wanted

Repository metrics

Stars
 (12,930 stars)
PR merge metrics
 (Avg merge 4d 12h) (22 merged PRs in 30d)

Description

In version 1.6.0, the following command cannot be used

Describe the bug

In version 1.6.0, the following command cannot be used.

pipx inject ansible-core --force ansible

error: unrecognized arguments: ansible

While adjusting the order can work

pipx inject ansible-core ansible --force

But this will create compatibility issues, the current way used in devcontainers is

features/src/pipx-package/install.sh at 9a1d24b27b2d1ea8916ebe49c9ce674375dced27 · devcontainers-contrib/features

[Bug]: Failed to build ansible feature · Issue #607 · devcontainers-contrib/features (github.com)

This is related to HIGH: pipx install --global order broken in 1.6.0 · Issue #1443 · pypa/pipx

Contributor guide

Research direction
Investigate the CLI argument parsing code, likely in the `pipx/` directory. Compare the behavior of `pipx inject` with and without ` force` positional argument. The issue is related to a change in version 1.6.0 that introduced strict positional parsing. Look at the argparse configuration for the inject subcommand. Also review the linked issue #1443 for context on the global command being broken.
Tech stack
python
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Pythonpipx usageCLI argument parsing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85