publiclab/mapknitter

Limit file upload size

Open

#328 opened on Feb 7, 2019

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)Ruby (203 forks)auto 404
bughelp wanted

Repository metrics

Stars
 (274 stars)
PR merge metrics
 (PR metrics pending)

Description

We currently allow users to upload files of size greater than 10 mb despite the fact that Image Upload tab carries note - "10mb max" for file size.

I uploaded the image of size 16.2 MB here- https://mapknitter.org/maps/lireille and no error was thrown.

The goal of this issue is to throw the error if file size if greater than 10mb.

Relevant issues: https://github.com/publiclab/mapknitter/issues/105 https://github.com/publiclab/mapknitter/issues/203

Thanks!

Contributor guide

Research direction
Find the file upload handler in the Ruby backend, add a check for file size before processing, and return an error if size exceeds 10 MB.
Tech stack
ruby
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RubyFile upload handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85