probcomp/curve-fitting

Turn opacity-scale into a multimethod that dispatches on mode

Open

#53 opened on Nov 27, 2018

View on GitHub
 (0 comments) (0 reactions) (1 assignee)Clojure (3 forks)auto 404
good first issuerefactor

Repository metrics

Stars
 (3 stars)
PR merge metrics
 (PR metrics pending)

Description

Currently we switch between opacity scales like so:

(let [make-opacity-scale (case mode
                           :resampling resampling/make-opacity-scale
                           :prior prior/make-opacity-scale)
      opacity-scale (make-opacity-scale (map :log-score curves))])

Instead we should define a multimethod curve-fitting.core/opacity-scale (or maybe curve-fitting.sketches/opacity-scale that takes two arguments: The mode and the log scores.

Contributor guide

Research direction
Create a multimethod `curve fitting.core/opacity scale` that dispatches on the mode argument. Move the case based switching logic into separate methods for each mode (e.g., :resampling and :prior). Update the caller to use the multimethod instead of the case expression.
Tech stack
clojure
Domain
backenddata
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ClojureGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65