pingcap/tidb

Able to set AUTO_INCREMENT to a value larger than maximum value of int

Open

#56,034 opened on Sep 12, 2024

View on GitHub
 (10 comments) (0 reactions) (2 assignees)Go (6,186 forks)batch import
component/ddlgood first issueseverity/moderatetype/bug

Repository metrics

Stars
 (40,090 stars)
PR merge metrics
 (Avg merge 14d 4h) (369 merged PRs in 30d)

Description

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

  1. create a table with auto increment, and set AUTO_INCREMENT=2147483648, while max value for int is 2147483647 (https://docs.pingcap.com/tidb/stable/data-type-numeric#integer-type)
  2. insert into the value using auto increment
mysql> create table t1 (a int auto_increment) AUTO_INCREMENT=2147483648;
Query OK, 0 rows affected (0.07 sec)

mysql> insert into t1 values ();
ERROR 1690 (22003): constant 2147483648 overflows int

2. What did you expect to see? (Required)

Create table should fail or user should be notified/warned in this case.

3. What did you see instead (Required)

Create table is OK, but later insert fails.

4. What is your TiDB version? (Required)

v8.4.0-alpha Edition: Community Git Commit Hash: f9c4773ba34854cec93dec3c5cae8a625925f9e9 Git Branch: heads/refs/tags/v8.4.0-alpha

Contributor guide

Research direction
The issue is that setting AUTO INCREMENT to a value larger than INT max should be rejected. Look into the DDL validation logic, likely in the 'ddl' package, where AUTO INCREMENT values are checked. The relevant code might be in 'ddl/table.go' or similar. Ensure that a max value check is added when parsing AUTO INCREMENT option.
Tech stack
gosql
Domain
database
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
SQL basicsInteger overflow concept
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50