pedrovgs/Shot

Support dynamic-feature Modules

Open

#256 opened on Sep 10, 2021

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)Kotlin (111 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (1,208 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Expected behaviour

Can test individual views within dynamic feature modules without testing the entire app.

Actual behaviour

Looks like the tests fail to run:

java.util.concurrent.ExecutionException: com.android.tools.build.bundletool.model.exceptions.InvalidCommandException: The APK Set archive does not contain the following modules: [name-of-dynamic-feature-module]

Steps to reproduce

Follow setup steps for Shot on a dynamic feature module, and run tests.

Version of the library

5.11.2

It could be that there's something wrong locally, but before closing, could y'all confirm that this is supposed to work on DFMs?

Contributor guide

Research direction
Investigate how Shot handles the APK set archive for dynamic feature modules and trace the test runner configuration.
Tech stack
kotlinandroid
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
AndroidKotlinGradle
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70