pedrovgs/Shot

Saving screenshots results in permission denied error.

Open

#230 opened on May 19, 2021

View on GitHubContributor guide
 (4 comments) (0 reactions) (0 assignees)Kotlin (111 forks)github user discovery
bughelp wanted

Repository metrics

Stars
 (1,208 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Expected behaviour

Saving screenshots saves properly.

Actual behaviour

Test fails with the following stack trace.

E/TestRunner: java.io.IOException: Permission denied
        at java.io.UnixFileSystem.createFileExclusively0(Native Method)
        at java.io.UnixFileSystem.createFileExclusively(UnixFileSystem.java:317)
        at java.io.File.createNewFile(File.java:1008)
        at com.karumi.shot.compose.ScreenshotSaver.createFileIfNotExists(ScreenshotSaver.kt:77)
        at com.karumi.shot.compose.ScreenshotSaver.saveScreenshotBitmap(ScreenshotSaver.kt:59)
        at com.karumi.shot.compose.ScreenshotSaver.saveScreenshot(ScreenshotSaver.kt:21)
        at com.karumi.shot.compose.ComposeScreenshot.saveScreenshot(ComposeScreenshot.kt:22)
        at com.karumi.shot.ScreenshotTest$DefaultImpls.compareScreenshot(ScreenshotTest.kt:144)

Steps to reproduce

  1. Sample repo provided here: https://github.com/davidliu/ShotSaveBug
  2. Run test.

Notably, the screenshot dirs are not created (the mkdirs fails with a false return value).

Version of the library

5.10.5

Contributor guide

Research direction
Check the file path and ensure the directory exists before saving screenshots. The mkdirs returns false, so investigate why directory creation fails. Ensure the app has write permission to external storage if needed.
Tech stack
kotlin
Domain
mobile dev
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
AndroidKotlin
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60