pedrovgs/Shot

Allow null heights to make the screenshot to wrap content

Open

#110 opened on May 11, 2020

View on GitHubContributor guide
 (6 comments) (2 reactions) (0 assignees)Kotlin (111 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (1,208 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

This is very useful when taking screenshots of dynamic height views. We don't always force a view to have a height, and the underlying Facebook implementation allows it by simply not setting a height:

/*
     * Measure and layout the view. In this example we give an exact
     * width but all the height to be WRAP_CONTENT.
     */
    ViewHelpers.setupView(view)
      .setExactWidthDp(300)
      .layout();

Expected behaviour

If I send null as height, I want to take a screenshot with WRAP_CONTENT

Actual behaviour

If I send null as height, I have metrics.heightPixels (fullscreen) as a default

Steps to reproduce

compareScreenshot(
                view = view,
                heightInPx = null,
                widthInPx = 600
            )

Version of the library

4.1+, from the moment shot-android wrapper was released.

Contributor guide

Research direction
Look at the current height parameter usage in the screenshot capture code. Identify where heightInPx is checked and defaulted. Change the logic to use null to indicate wrap content (e.g., set height to 0 or unset). Ensure widthInPx is still required. Test with a dynamic height view.
Tech stack
kotlinandroid
Domain
mobiletesting
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Android developmentKotlin
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65